Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds updated type in timeouts dendrite #2196

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

This updates the timeout types as per newest update of aiohttp==3.10.0
Reference: https://github.com/orgs/opentensor/projects/19/views/10?pane=issue&itemId=73100013

@ibraheem-opentensor ibraheem-opentensor requested a review from a team August 1, 2024 21:07
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why 2 out of 3 e2e tests keep failing, but LGTM in terms of changes.

@ibraheem-opentensor ibraheem-opentensor merged commit 41b60b2 into staging Aug 1, 2024
31 of 33 checks passed
@thewhaleking thewhaleking deleted the fix/abe/aiohttp-timeout-type branch August 2, 2024 15:42
@thewhaleking
Copy link
Contributor

Crazy that I just dealt with this on btcli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants